Improve error validation infrastructure of Shape API
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to return those from all `add_` methods of the `Shape` API.
No errors are actually returned yet. This will follow in upcoming steps. This results in a lot of ugly `unwrap`s all over the code, but I think that's a worthwhile trade-off. Those `unwrap`s will go away, as error handling in the CAD kernel is cleaned up over time. The immediate benefit is, that unit-testing the `Shape` API becomes easier.
I'm about to merge the "invalid" cases into those, and this makes sure the name will still fit then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a
ValidationErrornow that can be returned, if something fails to validate. Most of its variants are unused as of now, but I've decided to leave them in, to document my design intent.Methods that already do validation are updated to return
ValidationError. All other method returnValidationResult, but actually never return the error variant. I expect that most of them will start doing validation, and returningValidationError, soon.This is a continuation of my work on #242 and #280.