Generate more correct shapes as result of 2D difference #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method they cover has been renamed a while ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Shapeinstance created as the result of a 2D difference isn't internally consistent. It contains objects that refer to other objects, which are part of one of the inputShapes, but not part of the result. As far as I can tell, this doesn't result in any bugs, but it limits algorithms that operate on the result'sShapeinstance.This pull request improves the situation, making the result not fully correct, but much more so. It should be good enough to rewrite the sweep algorithm, so it no longer causes vertex validation warnings. This is required to address #242, and there's a WIP version of this rewrite in #278.