Prepare the ground for vertex validation #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful for some changes I'm working on, and I can't think of a reason against it.
The sketch code relied on vertex iteration order, which limits the changes we can make to vertex storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all necessary preparations for implementing vertex validation (#242). Literally, in my local branch, implementing vertex validation is the next commit after this.
Unfortunately, enabling vertex validation exposes bugs in the sweep code. Before trying to track those down, I figured it would be best to get the large majority of my changes merged, to prevent conflicts as far as possible. In addition, tracking down bugs in the current sweep code might not be the best use of time, seeing how cleaning up the sweep code was the motivation for tackling vertex validation right now.