Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThreeMF to 0.5.0 #2248

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Update ThreeMF to 0.5.0 #2248

merged 1 commit into from
Mar 2, 2024

Conversation

IamTheCarl
Copy link
Contributor

Comically minimum effort. Completes #2223 .

I intend to make some bigger changes later but I figured this PR would be an easier starting point.

For my next PR I'd like to adapt the export_3mf, export_stl, and export_obj functions to accept anything implementing std::io::Write instead of a file path, add documentation comments, and then make them public.

@IamTheCarl IamTheCarl requested a review from hannobraun as a code owner March 2, 2024 08:30
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IamTheCarl, looks great!

Comically minimum effort.

Perfect! Every improvement is worth merging.

For my next PR I'd like to adapt the export_3mf, export_stl, and export_obj functions to accept anything implementing std::io::Write instead of a file path, add documentation comments, and then make them public.

Sounds great!

@hannobraun hannobraun merged commit 81c971e into hannobraun:main Mar 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants