Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require dropping validation layer to handle validation errors #2216

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

hannobraun
Copy link
Owner

Build on top of #2215 to implement a command that takes all errors out of the validation layer. Before, you needed to drop the validation layer to handle validation errors, which is no longer necessary. That makes code doing this more flexible (as dropping the validation layer made fj_core::Instance unusable), which I need to make progress on #2117.

It is an improvement over `into_result` as it doesn't require dropping
the validation layer.
@hannobraun hannobraun enabled auto-merge February 15, 2024 12:18
@hannobraun hannobraun merged commit b5d0c79 into main Feb 15, 2024
4 checks passed
@hannobraun hannobraun deleted the validation branch February 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant