Clean up the layers code #2213
Merged
Clean up the layers code #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the convention set by other layers (both those finished and those currently being worked on), which all only have the layer-specific stuff within `layers`, while leaving the rest outside.
This is part of an effort to make the naming more regular and predictable.
This is part of an effort to make the `layers` API more regular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making progress on #2117 again, and as I'm working on adding the presentation layer, I'm running into inconsistencies and ugliness. This is a cleanup effort with the goal of making the layers code nicer and more regular, in preparation of adding the presentation layer.