Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require &mut Instance in Insert::insert #2207

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Require &mut Instance in Insert::insert #2207

merged 1 commit into from
Feb 12, 2024

Conversation

hannobraun
Copy link
Owner

This makes calling it more convenient (as all code already has a &mut Instance available directly, and with this change no longer has to access the field).

It also has the advantage of not exposing Instance internals to all code calling insert.

This comes out of my experimentation related to #2117.

This makes calling it more convenient (as all code already has a `&mut
Instance` available directly, and with this change no longer has to
access the field).

It also has the advantage of not exposing `Instance` internals to all
code calling `insert`.
@hannobraun hannobraun enabled auto-merge February 12, 2024 14:00
@hannobraun hannobraun merged commit 3a838bf into main Feb 12, 2024
4 checks passed
@hannobraun hannobraun deleted the insert branch February 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant