Code

Object Reference Validation #2133#2144

Code

Merged

hannobraun merged 20 commits intohannobraun:mainhannobraun/fornjot:mainfrom nathan-folsom:object-ownership-validationnathan-folsom/fornjot:object-ownership-validationCopy head branch name to clipboardJan 14, 2024

+505-7

Commits

Commits on Jan 14, 2024

• Initial implementation of validating HalfEdges only used by one Cycle in Sketch

  

  nathan-folsom

  authored and

  hannobraun

  committed
  19a1d03

• Test that validation succeeds for valid sketch as well as fails for invalid sketch

  

  nathan-folsom

  authored and

  hannobraun

  committed
  bfde2c7

• Implement validation of Cycle references within Sketch Regions

  

  nathan-folsom

  authored and

  hannobraun

  committed
  bb97038

• Implement Solid reference count validation

  

  nathan-folsom

  authored and

  hannobraun

  committed
  01d976e

• fix reference checks in wrong place

  

  nathan-folsom

  authored and

  hannobraun

  committed
  f4d6c92

• Unit test shell object reference validations

  

  nathan-folsom

  authored and

  hannobraun

  committed
  0e672fe

• Fix doc refence

  

  nathan-folsom

  authored and

  hannobraun

  committed
  224f892

• Align error messages

  

  nathan-folsom

  authored and

  hannobraun

  committed
  cf761c2

• use hashmap entry api

  

  nathan-folsom

  authored and

  hannobraun

  committed
  a8e612a

• create reference counter utility struct

  

  nathan-folsom

  authored and

  hannobraun

  committed
  56b387f

• write abstraction for validating reference counts

  

  nathan-folsom

  authored and

  hannobraun

  committed
  5224cc1

• make reference count error be contained within the object's error type

  

  nathan-folsom

  authored and

  hannobraun

  committed
  5a51f7d

• cleanup docs

  

  nathan-folsom

  authored and

  hannobraun

  committed
  81e1c8e

• store both referenced and referencing objects for better error messages

  

  nathan-folsom

  authored and

  hannobraun

  committed
  2f2d723

• show referencing and referenced objects in error message

  

  nathan-folsom

  authored and

  hannobraun

  committed
  3bdb468

• rename for clarity

  

  nathan-folsom

  authored and

  hannobraun

  committed
  2d2506b

• cleanup, remove todos

  

  nathan-folsom

  authored and

  hannobraun

  committed
  0900ef8

• Make DerefMut impl on Service only available in tests

  

  nathan-folsom

  authored and

  hannobraun

  committed
  8411b17

• Fix typo in method name

  

  nathan-folsom

  authored and

  hannobraun

  committed
  16e18e1

• Make clippy happy with import

  

  nathan-folsom

  authored and

  hannobraun

  committed
  cdcf015