Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly document validation infrastructure #2061

Merged
merged 7 commits into from
Oct 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Match order of validation errors and checks
hannobraun committed Oct 19, 2023
commit b65b7e72c2b39ecf4d9d0d6a87a7518185ff4e00
8 changes: 4 additions & 4 deletions crates/fj-core/src/validate/shell.rs
Original file line number Diff line number Diff line change
@@ -35,10 +35,6 @@ pub enum ShellValidationError {
)]
CurveCoordinateSystemMismatch(Vec<CurveCoordinateSystemMismatch>),

/// [`Shell`] is not watertight
#[error("Shell is not watertight")]
NotWatertight,

/// [`Shell`] contains edges that are coincident, but not identical
#[error(
"`Shell` contains `Edge`s that are coincident but refer to different \
@@ -70,6 +66,10 @@ pub enum ShellValidationError {
surface_b: Handle<Surface>,
},

/// [`Shell`] is not watertight
#[error("Shell is not watertight")]
NotWatertight,

/// [`Shell`] contains faces of mixed orientation (inwards and outwards)
#[error("Shell has mixed face orientations")]
MixedOrientations,