Lift limitation, that coincident Edges must be congruent
#2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the removed comment, or the (still available) documentation in `Edge` to learn more about that limitation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the culmination of lots of work over many weeks. I've refactored the object graph and wrote new (non-trivial) infrastructure for caching curve approximations. This pull request takes the final step in that journey, using that new infrastructure to make edge approximation more flexible.
As a result, it should now be possible to have coincident edges that are not fully congruent. This should enable more useful modeling tools to be built. The one I have in mind, which motivated this work in the first place, is an API for splitting a face (which would have otherwise been more complicated to implement, and less convenient for the user). But this makes the representation of geometry more flexible overall, and is sure to be useful yet unforeseen ways.
Please note that this new flexibility is not exercised, as the tools it enables don't exist yet. There might still be bugs, and those can be addressed as they come up, but the big architectural hurdles are out of the way now.
Close #1937