Further prepare for more sophisticated curve approximation #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curve insertion *returned* the correct curve segment, which means either the existing segment, if there is one, or the new one being inserted. But it actually *inserted* the wrong one, i.e. the new one. I don't think this lead to any bugs, due to the current usage patterns of the cache API, but it's wrong none the less, and a bug waiting to happen.
This is a pure refactoring, but it paves the way for merging curve approximations in more interesting ways in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test suite for
CurveApproxCache, fix a bug, and move the cache more towards what it needs to be, to support more flexible caching. This is more progress towards #1937, specifically the work described in #1937 (comment).