Merge BoundaryOnCurve and BoundingVertices
#1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can help prevent mistakes, since the method does not modify the existing instance.
This is preparation for merging `BoundingVertices` into it.
This is preparation for merging `BoundingVertices` into `BoundaryOnCurve`.
The new name seems a bit simpler, but no less expressive.
This is preparation for making `CurveBoundary` more convenient to specify, by preventing implementation details from leaking into the type signature.
This is preparation for improving some of the trait implementations on `CurveBoundary`.
Deriving doesn't work well with the associated type. It decides whether it should derive based on `T`, but whether it actually *can* derive is based on `T::Repr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already was some redundancy between those two structs, and my work on #1937 introduces more use cases that would have added more. Unifying them into a single, generic struct seems like the way to go.