Remove horrible hack #1951
Merged
Remove horrible hack #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, as the comment suspected, this did come back to bite me! Fortunately not in a bad way, as I found this comment pretty quick while figuring out what was wrong with the new code I wrote. But honestly, I'm surprised that it lasted this long (almost 10 months!). To my delight, removing this hack required no changes to any code! I take that as a sign that we're in a much better position today, architecture-wise, then we were back then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, as the comment suspected, this did come back to bite me! Fortunately not in a bad way, as I found this comment pretty quick while figuring out what was wrong with the new code I wrote. But honestly, I'm surprised that it lasted this long (almost 10 months!).
To my delight, removing this hack required no changes to any code! I take that as a sign that we're in a much better position today, architecture-wise, then we were back then.