Move fj-window to fornjot-extra
#1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has also been moved to fornjot-extra: https://github.com/hannobraun/fornjot-extra
hannobraun
changed the title
fj-window to fornjot-extrafj-window to fornjot-extra
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1822,
fj-windowhas also been moved to fornjot-extra. I had originally intended to keep it, but there are problems with that.First, there's #1736, which breaks the setup in fornjot-extras. While the crates there aren't actively maintained anymore, I'd strongly prefer to start that repository out with a setup that actually works.
Second, there's lots of code in
fj-windowthat is tied to that whole app-centric model of Fornjot models. While we definitely still need anfj-window-like crate in the new library-centric world, it's probably easier to just start fresh with that one.