Use Handle<Cycle> instead of Partial<Cycle> for PartialFace exterior
#1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a proper mess at all the call sites. I hope, but don't know, that this will clear up with further work. For now, I see no alternative to just forging ahead and see where that takes us.
This makes a proper mess at the call site. I hope, but don't know, that this will clear up with further work. For now, I see no alternative to just forging ahead and see where that takes us.
This duplicates some code from the `PartialCycle` implementation, which is fine, as the new implementation is meant to replace the old one shortly.
Verifying this on construction is becoming too limiting. And it is not necessary. We only need half-edges once we need to determine the cycle's winding. `Cycle::winding` can panic all by itself and doesn't need the constructor for that.
hannobraun
changed the title
Handle<Cycle> instead of Partial<Cycle> for `PartialFace exteriorHandle<Cycle> instead of Partial<Cycle> for PartialFace exterior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one less place where
PartialCycleis used and thus one more step towards removingPartialCyclein favor ofCycle. This is another step towards addressing #1570.