Remove redundant references to Vertex from GlobalEdge
#1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit is going to make it redundant.
They were redundant, as they are already available through `HalfEdge`.
With its references to `Vertex` removed, the `Eq`/`PartialEq`/`Ord`/ `PartialOrd` implementations of `GlobalEdge` are misleading and about to be removed. `HandleWrapper` is needed here, so `HalfEdge` can still derive those traits itself.
It used to test the normalized ordering of `GlobalEdge`'s references to `Vertex`, so it is no longer relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those references were already available through
HalfEdge, making them redundant. Removing them enabled a surprising amount of simplifications, which are also included in this pull request.Close #1643