Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue cleanup of HalfEdge #1536

Merged
merged 8 commits into from
Jan 25, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update method name
hannobraun committed Jan 25, 2023

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
commit 9d0090c5c9842a0a134a4968302c301a7efc3248
4 changes: 2 additions & 2 deletions crates/fj-kernel/src/validate/cycle.rs
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ impl Validate for Cycle {
errors: &mut Vec<ValidationError>,
) {
CycleValidationError::check_half_edge_connections(self, errors);
CycleValidationError::check_position(self, config, errors);
CycleValidationError::check_half_edge_boundaries(self, config, errors);

// We don't need to check that all half-edges are defined in the same
// surface. We already check that they are connected by identical
@@ -85,7 +85,7 @@ impl CycleValidationError {
}
}

fn check_position(
fn check_half_edge_boundaries(
cycle: &Cycle,
config: &ValidationConfig,
errors: &mut Vec<ValidationError>,