Remove default Angle wrapping behavior
#1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CAD applications, it's often useful to work with negative angles (where the direction is significant) or angles with a magnitude greater than 1 revolution (such as for helical sweeps or mechanical simulations). `Angle` is currently only used to specify rotations, where wrapping doesn't matter. This commit removes the default wrapping behavior, which can still be accessed manually as needed using `Angle::normalized`. It may still be worth exploring automatic wrapping solutions in the future to reduce floating point inaccuracy across repeated calculations, but it's unlikely to cause problems any time soon.
hannobraun
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Thank you, @antonok-edm! The change looks great, and your reasoning makes perfect sense. Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #100 (comment), and the commit message here