Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace robust-predicates #1468

Merged
merged 50 commits into from
Dec 20, 2022
Merged

Replace robust-predicates #1468

merged 50 commits into from
Dec 20, 2022

Conversation

hannobraun
Copy link
Owner

robust-predicates contains C code, which has caused issues with cross-compilation in the past (see #1278, for example). This pull request replaces it as a dependency, with two components:

  • robust, a pure-Rust library created from the same C code. It only provides 2D predicates, unfortunately, meaning it isn't a full replacement.
  • fj_math::robust, a new module in fj-math with transpiled code from the same C source, which provides the missing 3D predicate.

Adding all this code isn't ideal, but since this comes from an old and stable C library (public domain, no less), I don't think it will be much of a problem. Still, it would be better to contribute the missing predicate to robust instead. I've decided against that for now, as I don't have any tests for this code, beyond the indirect coverage of our own test suite.

I will monitor how the new code works out, and might re-evaluate this decision at a later point.

@hannobraun hannobraun enabled auto-merge December 20, 2022 22:07
@hannobraun hannobraun merged commit b596faf into main Dec 20, 2022
@hannobraun hannobraun deleted the robust branch December 20, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant