Start replacing old partial object API #1429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request starts the gradual process of replacing the old partial object API with the new one. It is a follow-up to #1428, which added the new partial object API. The goal is to eventually address #1249.
This replacements starts at the leaf nodes of the object graph, and I've been working my way up. So far,
PartialSurface
,PartialGlobalCurve
,PartialCurve
,PartialGlobalVertex
,PartialSurfaceVertex
, andPartialVertex
have been replaced. This has shown a few things already:PartialCycle::build
that just disappeared. No replacement was necessary. It's just no longer needed, due to the inherent properties of the new API. And this wasn't trivial code. It was hard to get right in the first place, and even harder to get into a semi-decent form.The next steps from here are as follows:
That last point is critical, and something I haven't really started doing so far. If the implementation of the partial object API gets simpler due to all of this, then it will be a win. But unless the new API will also be much easier to use correctly than the old one, it will not be enough.