Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vector<2>::cross #1065

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Add Vector<2>::cross #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af72f4
Derive some traits for `Winding`
hannobraun Sep 9, 2022
3397f3e
Add `Vector<2>::cross`
hannobraun Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/fj-math/src/triangle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ pub struct NotATriangle<const D: usize> {
}

/// Winding direction of a triangle.
#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash, Ord, PartialOrd)]
pub enum Winding {
/// Counter-clockwise
Ccw,
Expand Down
5 changes: 5 additions & 0 deletions crates/fj-math/src/vector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ impl Vector<2> {
pub fn unit_v() -> Self {
Vector::from([1., 0.])
}

/// Compute the 2D cross product with another vector
pub fn cross(&self, other: &Self) -> Scalar {
(self.u * other.v) - (self.v * other.u)
}
}

impl Vector<3> {
Expand Down