Rewrite edge sweeping algorithm #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make a difference right now, but makes a following change smaller.
This test is going to be difficult to keep working with the rewritten edge sweep operation that I'm working on, just like the other test that is already disabled became diffult before. I hope that I can re-enable both, once curves are made irreversible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old edge sweeping code did some dodgy things that could easily lead to bugs (case in point: #1031 (comment)). It also made assumptions that were incompatible with #1020. This rewritten code fixes all that, at the cost of some verbosity (and a disabled test).
This isn't exactly the end of the journey, but I think it leaves us in a better position in regards to future changes.