-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release automation can fail, because just-published crate is not found #788
Comments
The last run partially failed because of #788.
The previous one failed again, due to #788.
Here's the same thing happening again: https://github.com/hannobraun/Fornjot/runs/7235972641?check_suite_focus=true This seems to be a common occurrence, which makes this issue a high priority. |
And another one: https://github.com/hannobraun/Fornjot/runs/7236214289?check_suite_focus=true This absolutely needs to be fixed before the next release. |
I would propose to go with the option "After publishing a crate, query crates.io until it is available." I think it is the cleanest approach. I will open a pull request with a fix. |
FYI: it is a known issue rust-lang/cargo#9507 |
I agree.
Thank you! By the way, I know I said this absolutely needs to be fixed before the next release, but... I changed my mind 😄 This issue is very annoying, but it is not critical. It just makes the release take more time. #538 on the other hand is critical, as it could cause problems to be missed completely. So fixing #538 is actually more important, and we might want to keep this issue around as a ready source of errors to test fixes to #538 with. |
A fix for #788 has been merged since the previous attempt.
This issue has not been fixed, unfortunately! From here: https://github.com/hannobraun/Fornjot/runs/7389324150?check_suite_focus=true Seems like the behavior of crates.io is less rational than we expected. I think that makes "retry publish until it works" the best option. |
Check out this run of the CD pipeline: https://github.com/hannobraun/Fornjot/runs/7235683927?check_suite_focus=true
fj
is being published successfully, but right after,fj-host
fails, because it can't findfj
. I suspect this is due to caching on crates.io.I'm not sure what the best way to fix this is, but here are some ideas:
cargo publish
fails for this specific reasonThe text was updated successfully, but these errors were encountered: