Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid face orientation when sweeping in the negative direction #506

Closed
hannobraun opened this issue Apr 26, 2022 · 0 comments
Closed

Invalid face orientation when sweeping in the negative direction #506

hannobraun opened this issue Apr 26, 2022 · 0 comments
Labels
topic: core Issues relating to core geometry, operations, algorithms type: bug Something isn't working
Milestone
Straight edges, f...

Comments

@hannobraun
Copy link
Owner

As of #505, sweeping in arbitrary directions is supported. This can lead to face orientation issues, when sweeping downwards:
Screenshot from 2022-04-26 15-11-29

The best way to address this is probably to catch that case in the kernel, and invert the surfaces accordingly.
@hannobraun hannobraun added type: bug Something isn't working topic: core Issues relating to core geometry, operations, algorithms labels Apr 26, 2022
gabsi26 added a commit to gabsi26/Fornjot that referenced this issue May 24, 2022
@gabsi26
Invert surface for negative sweep path fixes hannobraun#506
7843bf7 
Checks if the path points in negative z-direction
and flips surface normal accordingly

this is sufficient as long as sketches are always drawn in the xy-plane
if this ever changes this has to be revisited

Signed-off-by: gabsi26 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: core Issues relating to core geometry, operations, algorithms type: bug Something isn't working
Projects
None yet
Milestone
Straight edges, flat faces, simple sk...
Development

No branches or pull requests
1 participant
@hannobraun