Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment type of tolerance command line parameter #360

Closed
mxdamien opened this issue Mar 16, 2022 · 1 comment · Fixed by #359
Closed

Fix comment type of tolerance command line parameter #360

mxdamien opened this issue Mar 16, 2022 · 1 comment · Fixed by #359

Comments

@mxdamien
Copy link
Contributor

Hi !

When adding a command line parameter for model deviation tolerance in #118 with 8c3e42f I used a regular comment instead of a documentation comment. Sorry for that.

see #359
@mxdamien mxdamien mentioned this issue Mar 16, 2022
Merged
@hannobraun
Copy link
Owner

Hey @mxdamien, thanks for opening this issue!

No need to apologize! I make mistakes like that all the time. And also, I missed this in review, so who's fault is it really? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change comment for tolerance command line argument to documentation c… mxdamien/Fornjot
2 participants
@hannobraun @mxdamien