Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tolerance overridable #118

Closed
hannobraun opened this issue Jan 31, 2022 · 1 comment · Fixed by #352
Closed

Make tolerance overridable #118

hannobraun opened this issue Jan 31, 2022 · 1 comment · Fixed by #352
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

hannobraun commented Jan 31, 2022

Fornjot works with a tolerance value, that specifies how far a generated triangle mesh is allowed to deviate from the ideal geometry that a model defines. Right now, this value is computed automatically, based on the total size of the model. This is fine as a fallback, but the user should be able to override this value.

A command-line argument can be added in args.rs and then processed in main.rs. As of this writing, the tolerance is also computed in main.rs, so integrating an argument there should be straight-forward. Labeling as https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as this is a small change that doesn't require much knowledge of Fornjot.

@hannobraun hannobraun added type: feature New features and improvements to existing features good first issue Good for newcomers topic: ui labels Jan 31, 2022
@mxdamien
Copy link
Contributor

mxdamien commented Mar 15, 2022

Hey ! :)

See #352 for a suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants