Skip to content

Commit

Permalink
Improve clarity of parameter name
Browse files Browse the repository at this point in the history
  • Loading branch information
hannobraun committed Mar 8, 2022
1 parent 2bf0432 commit ef056a1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/kernel/algorithms/sweep.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use super::{approximation::Approximation, transform::transform_face};

/// Create a new shape by sweeping an existing one
pub fn sweep_shape(
mut original: Shape,
mut shape_orig: Shape,
path: Vector<3>,
tolerance: Scalar,
) -> Shape {
Expand All @@ -22,7 +22,7 @@ pub fn sweep_shape(
let mut top_faces = Vec::new();
let mut side_faces = Vec::new();

for face in original.faces().all() {
for face in shape_orig.faces().all() {
bottom_faces.push(face.clone());

// TASK: This can only work, if all the original faces don't share any
Expand All @@ -31,7 +31,7 @@ pub fn sweep_shape(
top_faces.push(transform_face(&face, &translation, &mut shape));
}

for cycle in original.cycles().all() {
for cycle in shape_orig.cycles().all() {
let approx = Approximation::for_cycle(&cycle, tolerance);

// This will only work correctly, if the cycle consists of one edge. If
Expand Down

0 comments on commit ef056a1

Please sign in to comment.