Merge pull request #604 from chrisprice/improve-error-handling-feedback

Improve Error::InvalidExtension message & docs
hannobraun · May 19, 2022 · e5106e7 · e5106e7
2 parents 728ba1f + c7bafad
commit e5106e7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/crates/fj-export/src/lib.rs b/crates/fj-export/src/lib.rs
@@ -36,7 +36,7 @@ pub fn export(mesh: &Mesh<Point<3>>, path: &Path) -> Result<(), Error> {
             export_stl(mesh, path)
         }
         Some(extension) => Err(Error::InvalidExtension(
-            extension.to_str().map(|s| s.to_string()),
+            extension.to_string_lossy().into_owned(),
         )),
         None => Err(Error::NoExtension),
     }
@@ -119,9 +119,9 @@ pub enum Error {
     #[error("no extension specified")]
     NoExtension,
 
-    /// Unrecognised extension found `{0:?}`
+    /// Unrecognised extension found
     #[error("unrecognised extension found `{0:?}`")]
-    InvalidExtension(Option<String>),
+    InvalidExtension(String),
 
     /// I/O error whilst exporting to file
     #[error("I/O error whilst exporting to file")]