Skip to content

Commit

Permalink
Merge pull request #988 from hannobraun/docs
Browse files Browse the repository at this point in the history
Improve comments and documentation in `fj-host`
  • Loading branch information
hannobraun authored Aug 24, 2022
2 parents 67cc32d + c64f94d commit b09f894
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions crates/fj-host/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,10 @@ pub struct Model {
}

impl Model {
/// Initialize the model using the path to its crate (i.e. the folder
/// containing `Cargo.toml`).
/// Initialize the model using the path to its crate
///
/// Optionally, the target directory where plugin files are compiled to can
/// be provided. If it is not provided, the target directory is assumed to
/// be located within the model path.
/// The path expected here is the root directory of the model's Cargo
/// package, that is the folder containing `Cargo.toml`.
pub fn from_path(path: PathBuf) -> Result<Self, Error> {
let crate_dir = path.canonicalize()?;

Expand Down Expand Up @@ -315,9 +313,9 @@ impl Watcher {
{
Ok(shape) => shape,
Err(Error::Compile) => {
// It would be better to display an error in the UI,
// where the user can actually see it. Issue:
// https://github.com/hannobraun/fornjot/issues/30
// An error is being displayed to the user via the
// `StatusReport that is passed to `load_once` above, so
// no need to do anything else here.
return None;
}
Err(err) => {
Expand Down

0 comments on commit b09f894

Please sign in to comment.