Skip to content

Commit

Permalink
Fix dodgy assumption in edge sweeping code
Browse files Browse the repository at this point in the history
  • Loading branch information
hannobraun committed Sep 7, 2022
1 parent bf20515 commit 6d410f4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion crates/fj-kernel/src/algorithms/sweep/edge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ fn create_non_continuous_side_face(
let [_, prev_last] = edges[i].vertices().get_or_panic();
let [next_first, _] = edges[j].vertices().get_or_panic();

if prev_last.global_form() != next_first.global_form() {
// Need to compare surface forms here, as the global forms might be
// coincident when sweeping circles, despite the vertices being
// different!
if prev_last.surface_form() != next_first.surface_form() {
edges[j] = edges[j].reverse();
}

Expand Down

0 comments on commit 6d410f4

Please sign in to comment.