Skip to content

Commit

Permalink
Integrate export validation into "Test" job
Browse files Browse the repository at this point in the history
This has two advantages:

- It runs export validation on more platforms, which can help catch
  platform-specific issues.
- It saves one GitHub Actions job.
  • Loading branch information
hannobraun committed Oct 17, 2022
1 parent 587cdaa commit 6ba012f
Showing 1 changed file with 8 additions and 22 deletions.
30 changes: 8 additions & 22 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,28 +92,6 @@ jobs:
env:
RUSTDOCFLAGS: -D warnings

export:
name: Validate 3MF Export
runs-on: ubuntu-latest
steps:
- name: Check out repository
uses: actions/checkout@v3
- name: Set up toolchain
uses: oxidecomputer/actions-rs_toolchain@oxide/master
# see https://github.com/actions-rs/toolchain/pull/209
# uses: actions-rs/toolchain@v1
with:
override: true
profile: minimal
target: ${{ matrix.target }}
- name: Set up Rust cache
uses: Swatinem/rust-cache@1232abb8968faf344409165de17cbf9e7f340fd8
- name: Run `export-validator`
uses: actions-rs/cargo@4ff6ec2846f6e7217c1a9b0b503506665f134c4b
with:
command: run
args: --package export-validator

test:
name: Test
strategy:
Expand Down Expand Up @@ -148,3 +126,11 @@ jobs:
with:
command: test
args: --all-features
- name: Run `export-validator`
uses: actions-rs/cargo@4ff6ec2846f6e7217c1a9b0b503506665f134c4b
with:
command: run
args: --package export-validator
# Export Validator doesn't support Windows yet. Issue:
# https://github.com/hannobraun/Fornjot/issues/920
if: ${{ matrix.os != 'windows-latest' }}

0 comments on commit 6ba012f

Please sign in to comment.