Skip to content

Commit

Permalink
Use SurfaceVertex in Cycle validation
Browse files Browse the repository at this point in the history
I'm not completely sure if this actually makes a difference, but I think
it can rule out some weird edge cases, where global vertices are
coincident because the surface connects to itself.
  • Loading branch information
hannobraun committed Sep 6, 2022
1 parent 28670fc commit 53a7c2e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions crates/fj-kernel/src/objects/cycle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ impl Cycle {
let [next, _] = b.vertices().get_or_panic();

assert_eq!(
prev.global_form(),
next.global_form(),
prev.surface_form(),
next.surface_form(),
"Edges in cycle do not connect"
);
}
Expand All @@ -68,8 +68,8 @@ impl Cycle {
let [_, last] = last.vertices().get_or_panic();

assert_eq!(
first.global_form(),
last.global_form(),
first.surface_form(),
last.surface_form(),
"Edges do not form a cycle"
);
}
Expand Down

0 comments on commit 53a7c2e

Please sign in to comment.