Return iterator from Sketch::into_faces

hannobraun · Jul 27, 2022 · 1e38028 · 1e38028
1 parent f488cb7
commit 1e38028
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/crates/fj-kernel/src/algorithms/transform.rs b/crates/fj-kernel/src/algorithms/transform.rs
@@ -102,10 +102,7 @@ impl TransformObject for GlobalVertex {
 
 impl TransformObject for Sketch {
     fn transform(self, transform: &Transform) -> Self {
-        let faces = self
-            .into_faces()
-            .into_iter()
-            .map(|face| face.transform(transform));
+        let faces = self.into_faces().map(|face| face.transform(transform));
         Self::new().with_faces(faces)
     }
 }

diff --git a/crates/fj-kernel/src/objects/sketch.rs b/crates/fj-kernel/src/objects/sketch.rs
@@ -39,8 +39,8 @@ impl Sketch {
     }
 
     /// Convert the sketch into a list of faces
-    pub fn into_faces(self) -> BTreeSet<Face> {
-        self.faces
+    pub fn into_faces(self) -> impl Iterator<Item = Face> {
+        self.faces.into_iter()
     }
 }
 

diff --git a/crates/fj-operations/src/lib.rs b/crates/fj-operations/src/lib.rs
@@ -67,7 +67,6 @@ impl Shape for fj::Shape {
                     .compute_brep(config, tolerance, debug_info)?
                     .into_inner()
                     .into_faces()
-                    .into_iter()
                     .collect(),
                 config,
             ),