Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error::InvalidExtension message & docs #604

Merged
merged 1 commit into from
May 19, 2022
Merged

Improve Error::InvalidExtension message & docs #604

merged 1 commit into from
May 19, 2022

Conversation

chrisprice
Copy link
Contributor

Rounding out the feedback on #599

@chrisprice chrisprice requested a review from hannobraun as a code owner May 18, 2022 19:08
hannobraun
hannobraun approved these changes May 19, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @chrisprice! Looks great!

@hannobraun hannobraun merged commit e5106e7 into hannobraun:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisprice @hannobraun