Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line argument for user defined model tolerance #352

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Add command line argument for user defined model tolerance #352

merged 1 commit into from
Mar 15, 2022

Conversation

mxdamien
Copy link
Contributor

closes #118

@mxdamien mxdamien requested a review from hannobraun as a code owner March 15, 2022 10:23
@mxdamien mxdamien mentioned this pull request Mar 15, 2022
Closed
@mxdamien mxdamien force-pushed the feat/userDefinedTolerance branch 2 times, most recently from ff96a48 to a49fa0a Compare March 15, 2022 10:32
hannobraun
hannobraun reviewed Mar 15, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mxdamien! Great to see you back!

I've left a comment with a suggestion.

src/args.rs Outdated Show resolved Hide resolved
@mxdamien mxdamien force-pushed the feat/userDefinedTolerance branch from a49fa0a to 4c81324 Compare March 15, 2022 11:29
@mxdamien mxdamien force-pushed the feat/userDefinedTolerance branch from 4c81324 to 8c3e42f Compare March 15, 2022 11:32
hannobraun
hannobraun approved these changes Mar 15, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mxdamien, looks and works great!

@hannobraun hannobraun merged commit 35d07b2 into hannobraun:main Mar 15, 2022
@mxdamien mxdamien deleted the feat/userDefinedTolerance branch March 15, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tolerance overridable
2 participants
@mxdamien @hannobraun