Enable vertex validation #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hannobraun
force-pushed
the
validation
branch
5 times, most recently
from
79e2296 to
6753689
Compare
|
The sweep code has been fixed, and no longer causes vertex validation issues. I've updated the pull request description accordingly. There are still some issues in the transform code. I have a plan for fixing those, which I'm currently working on. |
hannobraun
force-pushed
the
validation
branch
2 times, most recently
from
6ce3009 to
a834107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertex validation ensures that vertices are unique: Different vertices that don't have a specific minimum distance to each other are considered identical, which is not allowed. This is a user-visible change that can lead to errors in models that would have previously been accepted.
The immediate advantage of this is, that it is no longer possible to accidentally create distinct vertices that were supposed to be identical, which is a source of bugs. Due to floating point accuracy issues, this kind of thing can easily happen, both in models and in kernel code.
Longer-term, this is the start of a strategy of requiring geometrical relationships to be explicit, and immediately failing if they aren't. I've started to document this.
Close #242