Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Fornjot to WebAssembly #1221

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Compile Fornjot to WebAssembly #1221

merged 9 commits into from
Oct 20, 2022

Conversation

hannobraun
Copy link
Owner

@hannobraun hannobraun commented Oct 14, 2022

Make sure all Fornjot crates compile to WebAssembly, except fj-app and fj-host (which, at least currently, can't support WASM by design) . Add a CI job to guard against regressions.

Includes a fork of robust-predicates. We can switch to the upstream version, as soon as hporro/robust-predicates#2 is merged, and a new version including it is released.

Close #815

@hannobraun hannobraun marked this pull request as draft October 14, 2022 11:33
@hannobraun hannobraun force-pushed the wasm branch 5 times, most recently from d312f0f to 853e1af Compare October 14, 2022 12:16
@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Oct 14, 2022
This seems like the way to go, given the current level of browser
support. I'm also getting a lot of compiler errors, when not enabling
this.
It should be the quickest, so why not check it first and fail fast.
@hannobraun hannobraun marked this pull request as ready for review October 20, 2022 10:09
@hannobraun hannobraun enabled auto-merge October 20, 2022 10:09
@hannobraun hannobraun disabled auto-merge October 20, 2022 10:10
@hannobraun hannobraun enabled auto-merge October 20, 2022 10:13
@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Oct 20, 2022
@hannobraun
Copy link
Owner Author

My pull requests have been merged and robust-predicates 0.1.4 it out! I've also fixed a few other issues that prevented compiling to WebAssembly and cleaned things up. This is good to go!

@hannobraun hannobraun merged commit 02efc43 into main Oct 20, 2022
@hannobraun hannobraun deleted the wasm branch October 20, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile Fornjot to WebAssembly
1 participant