-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile Fornjot to WebAssembly #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
wasm
branch
5 times, most recently
from
October 14, 2022 12:16
d312f0f
to
853e1af
Compare
hannobraun
added
the
status: blocked
Issue or pull request is blocked by another issue or pull request, or some outside circumstance
label
Oct 14, 2022
This version can be cross-compiled to WebAssembly.
This seems like the way to go, given the current level of browser support. I'm also getting a lot of compiler errors, when not enabling this.
It should be the quickest, so why not check it first and fail fast.
hannobraun
removed
the
status: blocked
Issue or pull request is blocked by another issue or pull request, or some outside circumstance
label
Oct 20, 2022
My pull requests have been merged and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all Fornjot crates compile to WebAssembly, except
fj-app
andfj-host
(which, at least currently, can't support WASM by design) . Add a CI job to guard against regressions.Includes a fork of
robust-predicates
. We can switch to the upstream version, as soon as hporro/robust-predicates#2 is merged, and a new version including it is released.Close #815