fix problem with video isMuted #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannadrehman
reviewed
Apr 5, 2024
| } | ||
| videoRef.current.play().catch(() => { | ||
|
|
||
| videoRef.current.play().then(() => { |
There was a problem hiding this comment.
will it not cause a play pause glitch ?
There was a problem hiding this comment.
No, these changes fix a problem with this issue on the top
There was a problem hiding this comment.
In the original code happens next error
DOMException: The play() request was interrupted because video-only background media was paused to save power
|
@Sasha-Zayets can u please rebase this branch |
the issue created seems to be different than this change. |
These changes will fix a problem when changing the story needs the correct mute or not video |
hannadrehman
approved these changes
Feb 25, 2025
|
@Sasha-Zayets please rebase this branch with master. i will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this issue #41