Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reparse more reliable #454

Merged
merged 6 commits into from
Jul 28, 2024
Merged

Make reparse more reliable #454

merged 6 commits into from
Jul 28, 2024

Conversation

handymenny
Copy link
Owner

  • Keep the original data if reparsing fails
  • Try to guess the subtype/RAT of type H inputs

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88%. Comparing base (9ac87de) to head (cd64e7d).

Files Patch % Lines
...phonecombo/uecapabilityparser/server/JavalinApp.kt 88% 2 Missing and 1 partial ⚠️
...phonecombo/uecapabilityparser/util/MultiParsing.kt 82% 0 Missing and 2 partials ⚠️
...t/smartphonecombo/uecapabilityparser/io/IOUtils.kt 80% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #454   +/-   ##
===================================
+ Coverage    88%    88%   +1%     
===================================
  Files       108    108           
  Lines      4834   4879   +45     
  Branches   1185   1195   +10     
===================================
+ Hits       4218   4261   +43     
  Misses      209    209           
- Partials    407    409    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@handymenny handymenny changed the title Makre reparse more reliable Make reparse more reliable Jul 28, 2024
@handymenny handymenny force-pushed the improve-reparse branch 2 times, most recently from cbb4526 to 0a232a4 Compare July 28, 2024 15:28
@handymenny handymenny merged commit 40028d7 into main Jul 28, 2024
6 checks passed
@handymenny handymenny deleted the improve-reparse branch July 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant