Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localhost to no-auth list #685

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Conversation

lukeburns
Copy link
Contributor

@pinheadmz
Copy link
Member

Tested this is in a kinda interesting way, using Docker dev environments which requires VSCode and the remote container extension for VSCode.

First I had to configure docker daemon to enable ipv6 by adding these to the configuration file:

  "ipv6": true,
  "fixed-cidr-v6": "2001:db8:1::/64"

Then I created a dev environment from my local hsd repo, you can see the loopback interface has both ipv4 and ipv6 addresses:

$ cat /proc/version 
Linux version 5.10.76-linuxkit (root@buildkitsandbox) (gcc (Alpine 10.2.1_pre1) 10.2.1 20201203, GNU ld (GNU Binutils) 2.35.2) #1 SMP PREEMPT Mon Nov 8 11:22:26 UTC 2021
$ sudo ifconfig lo
lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet 127.0.0.1  netmask 255.0.0.0
        inet6 ::1  prefixlen 128  scopeid 0x10<host>

Then I disabled the ipv4 address in /etc/hosts:

$ cat /etc/hosts 
#127.0.0.1      localhost
::1     localhost ip6-localhost ip6-loopback

This makes the http-test.js test fail all the way down, until this branch is applied for the fix!

Great work on this find, @lukeburns

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3a2a7a

Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK d3a2a7a164cf781a2387a5b03ad0c6c27d1ababf
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmIfxg0ACgkQ5+KYS2KJ
yTqaTQ/+NGLbvJam0pVhrWdSO/YjgPbxJAeDmylwjsKXdbf8nRnqBtT1HtwVcvyH
d8WcVfgOvgD5osGjAwq1CZHiAiFYPzN9j0eWg5AodBCQELMMwzQhC+o01aReP/oa
ZxHlTe0FGhauqPFPsybSljVq2FRw+itwAuIuEkmOc+VkNqPL63ZjqrP+jWyM6jtQ
2FkWMC+7I9Rxy4p864stUghsT3dhRTe7dQ+U6bQXuYaRSKts9vy+OsCSaV5J3+rF
0pXzsPRYJgD1D5ml7cArGfeebXNgcc5w39xuWCf/J94D5J/Hfl32cKLZvTt5lXjT
xk0T2hogJb4oOXj6xcWgsaSeWbc0DDC2KBiDoLWD8WqXL0fnw4aWkK/44FiGPTPh
pCoNDLc5meKWtvM9MrvUOL+JM+6OY8gIcQE8CTAjjAmp4lGXYQobypklhiNSxNCx
diFEVoVG49NJcAtG084kjScGAk9cLBsEu6EGMpjFjEIjgK2j7JMzYeL+wWP/U0nG
wmLVqG+B4L3RwCpKAkCN7YYUWj/gU/9FVbppbwezGfjNwZ5F4ArrsPiv7FUFKy7e
Uhb/JHhc4G67Wlqw350F8zoM0AMRl25hkNZiprUDyrTom1buWp2ObADwp61dFsoL
sd9Bjy4YMOaxtNNgWP+szZtF2xxywHJgKwefcngxl36klXLrg+c=
=AZXY
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

@pinheadmz pinheadmz merged commit 3f8ab84 into handshake-org:master Mar 2, 2022
@nodech nodech added the patch Release version label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants