Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network refactor #40

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Network refactor #40

merged 15 commits into from
Jul 26, 2024

Conversation

yallup
Copy link
Collaborator

@yallup yallup commented Jul 4, 2024

Description

Removes the torch dependency and all network code (now exists elsewhere to be joined up in the future)
No additional fitting dependencies introduced.

Also a couple of small changes to the README from running the suggested pre-commit commands (calling black . starts churning through everything in a venv environment if built in directory)

Checklist:

  • I have performed a self-review of my own code
  • My code is black compliant (black . --check)
  • My code is isort compliant (isort . --profile black --filter-files)
  • My code contains compliant docstrings (pydocstyle --convention=numpy lsbi)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and lsbi/_version.py

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (65e7ec2) to head (1293df3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         5    -1     
  Lines          546       475   -71     
=========================================
- Hits           546       475   -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yallup
Copy link
Collaborator Author

yallup commented Jul 4, 2024

Think I accidentally pulled changes from the branch dimensionality a while ago, I can remake without those or that can be merged first?

Copy link
Contributor

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the BMD changes -- please squash and merge @yallup

@yallup yallup merged commit 662af2e into master Jul 26, 2024
9 checks passed
@yallup yallup deleted the network_refactor branch July 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants