-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop warning when logL==logL_birth==-inf
#395
Conversation
…ntly drop those samples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 3058 3060 +2
=========================================
+ Hits 3058 3060 +2 ☔ View full report in Codecov by Sentry. |
Code changes are simple enough that I'm happy, but I wanted to ask what your use case is? |
I have a bunch of PolyChord runs that produce rows with These rows are not really a problem (since they have zero weight), so they can be dropped without a problem, and should not need the warning. The warning was created for situations of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Currently we issue a warning when
logL<=logL_birth
, which includes the caselogL==logL_birth==-inf
. The latter has come up a number of times in my latest runs, spamming me with warnings, which ultimately are nothing to worry about.This little PR silences this particular warning when
logL==logL_birth==-inf
is the only occurrence oflogL<=logL_birth
.Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)