Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict scipy and numpy versions #390

Merged

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Jul 2, 2024

Description

Restrict scipy and numpy versions to <2.0.0.

numpy 2.0 is currently incompatible, therefore, I think it's silly to assume nothing will happen whenever scipy eventually gets a major change (not on the horizon, see https://github.com/scipy/scipy/wiki/SciPy-2.0:-ideas-for-changes-&-cleanups)

Fixes #389

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@AdamOrmondroyd AdamOrmondroyd mentioned this pull request Jul 2, 2024
6 tasks
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5b6b199). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             master      #390   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        36           
  Lines             ?      3058           
  Branches          ?         0           
==========================================
  Hits              ?      3058           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd AdamOrmondroyd merged commit d367a4b into handley-lab:master Jul 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytables incompatible with numpy 2.0
2 participants