2 tick minimum also for logscale #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xis, unfortunately appears to have to be called after every call to `plot_2d`
…t changes but for some reason acts up
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 3032 3041 +9
=========================================
+ Hits 3032 3041 +9 ☔ View full report in Codecov by Sentry. |
lukashergt
commented
Mar 19, 2024
| @@ -355,6 +355,8 @@ def plot_2d(self, axes=None, *args, **kwargs): | |||
| else: | |||
| ax.plot([], []) | |||
|
|
|||
| axes._set_logticks() | |||
There was a problem hiding this comment.
I tried setting the log ticks in the same place where we generally deal with tick locations, but plot_2d overwrites these locations, so this call at the end of plot_2d is needed...
This reverts commit 50afec0.
…to recent changes but for some reason acts up" This reverts commit eba68c8.
…not robust across different figure sizes, where often the yaxis is shorter than the xaxis, which caused failures in some CI settings
…sses with other tests, make the test work with default settings instead
…test is not robust across different figure sizes, where often the yaxis is shorter than the xaxis, which caused failures in some CI settings" This reverts commit 3bcc92d.
williamjameshandley
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As raised in #362, logscales can lead to plots with only a single tick mark. This PR aims at fixing that, such that every plot has a minimum of 2 tick marks.
Fixes #362
Checklist:
flake8 anesthetic tests)pydocstyle --convention=numpy anesthetic)python -m pytest)