Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit to matplotlib<3.8.3 #365

Closed
wants to merge 2 commits into from
Closed

Conversation

williamjameshandley
Copy link
Collaborator

Description

Matplotlib 3.8.3 breaks anesthetic. Restricting to beneath this version until this is fixed.

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b93dec5) to head (d8055b2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2978      2978           
=========================================
  Hits          2978      2978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd
Copy link
Collaborator

Incredible 😢

@williamjameshandley
Copy link
Collaborator Author

Actually it's now less clear to me whether this is matplotlib 3.8.3, or python 3.12.

@AdamOrmondroyd
Copy link
Collaborator

I've been running almost exclusively on 3.12 locally since it released, so I would say probably not

@AdamOrmondroyd
Copy link
Collaborator

I've just run the test suite locally and no issues on my end, what were you seeing?

@williamjameshandley
Copy link
Collaborator Author

Ah -- is the CI/latest-dependencies breaking because of pandas 2.2.0, i.e. #359 ?

@AdamOrmondroyd
Copy link
Collaborator

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants