Restrict matplotlib < 3.8
#341
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 2858 2858
=========================================
Hits 2858 2858
☔ View full report in Codecov by Sentry. |
bin/min_dependencies.py
Outdated
| @@ -7,5 +7,6 @@ | |||
| deps = pyproject["project"]["dependencies"] | |||
| deps = [dep.replace(">=", "==") for dep in deps] | |||
| deps = [dep.replace("~=", "==") for dep in deps] | |||
| deps = [dep[:dep.find('<')-1] if '<' in dep else dep for dep in deps] | |||
There was a problem hiding this comment.
I don't like that this requires the upper bound to be written after the lower one
There was a problem hiding this comment.
How about
deps = ['"%s"' % dep for dep in deps]instead of that line?
There was a problem hiding this comment.
ah yes perfect, though I think I'll use f-strings instead.
There was a problem hiding this comment.
ahhhhh now it has too many sets of quotes :'(
There was a problem hiding this comment.
(same result with f-strings and %s formatting)
There was a problem hiding this comment.
Happy for this to be merged until #339 is ready. Thanks @AdamOrmondroyd
* Ignore "You are using [hist/kde] as a plot kind" warnings * hedge bets that #341 will merge first lol
Description
anestheticis currently incompatible withmatplotlib 3.8, so the installation has been restricted.This more complex dependency also required changes to
min_dependencies.pyFixes #340
Checklist:
flake8 anesthetic tests)pydocstyle --convention=numpy anesthetic)python -m pytest)