Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict to pandas2.0 #337

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Sep 12, 2023

Description

Upgrading to pandas2.1 has introduced a number of issues, so restrict to pandas2.0 in the meantime until #335 is ready.

Fixes #336

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@AdamOrmondroyd AdamOrmondroyd self-assigned this Sep 12, 2023
@AdamOrmondroyd AdamOrmondroyd added the bug Something isn't working label Sep 12, 2023
@AdamOrmondroyd AdamOrmondroyd marked this pull request as ready for review September 12, 2023 12:37
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1bddc80) 100.00% compared to head (2fdba20) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2858      2858           
=========================================
  Hits          2858      2858           
Files Changed Coverage Δ
anesthetic/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd AdamOrmondroyd merged commit 1754464 into handley-lab:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with pandas 2.1
2 participants