Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test_hdf5.h5 after test #309

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Jun 30, 2023

Description

Remove test_hdf5.h5 after performing the test.

Fixes #303

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c5e8fc) 100.00% compared to head (2d36cf4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2764      2764           
=========================================
  Hits          2764      2764           
Impacted Files Coverage Δ
anesthetic/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AdamOrmondroyd
Copy link
Collaborator Author

I've made the file names different for each root option, to avoid issues with the tests being run in parallel and accessing the file simultaneously

Copy link
Collaborator

@lukashergt lukashergt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tmp_path fixture did the trick. Thanks for initiating this, @AdamOrmondroyd, please squash and merge.

@AdamOrmondroyd AdamOrmondroyd merged commit cb2759c into handley-lab:master Jul 19, 2023
@AdamOrmondroyd
Copy link
Collaborator Author

Thanks @lukashergt, deffo need to get more on top of the pytest features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants