Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using handlebars with browserify causes IE to throw - TypeError: Invalid calling object #513

Merged
merged 1 commit into from
May 10, 2013
Merged

Using handlebars with browserify causes IE to throw - TypeError: Invalid calling object #513

merged 1 commit into from
May 10, 2013

Conversation

panthershark
Copy link

The isEmpty function in lib/utils uses a cached pointer to Object.prototype.toString. When a module is browserified, it is wrapped in a closure scope. In IE, there is a scope conflict which causes the use of the cached toString function pointer to result in

TypeError: Invalid calling object

Adding local cached pointer to Object's toString method resolves the issue.

isEmpty is used in the if helper.

kpdecker added a commit that referenced this pull request May 10, 2013
@kpdecker
Merge pull request #513 from tommydudebreaux/master
7cd9cdb 
Using handlebars with browserify causes IE to throw - TypeError: Invalid calling object
@kpdecker kpdecker merged commit 7cd9cdb into handlebars-lang:master May 10, 2013
@kpdecker
Copy link
Collaborator

Thanks!

@panthershark
Copy link
Author

Thank you so much. Any idea when you plan to publish npm?

@kpdecker
Copy link
Collaborator

I hope to publish an updated version over the weekend. We are trying to
sync the two release trains but getting that figured out is taking a bit
more time than it will in the future.

On Fri, May 10, 2013 at 9:02 AM, Tommy Messbauer
[email protected]:

Any idea when you plan to publish npm?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/513#issuecomment-17721835
.

@panthershark
Copy link
Author

No stress. Thanks for the update. Let Eric or I know if we can help.

alejandroiglesias added a commit to alejandroiglesias/handlebars.js that referenced this pull request May 27, 2013
@alejandroiglesias
Update to 1.0.11
c2c3808 
commit 5f34991
Author: kpdecker <[email protected]>
Date:   Mon May 27 12:29:57 2013 -0500

    Update in the wild section

    Fixes handlebars-lang#246

commit c1020a0
Author: kpdecker <[email protected]>
Date:   Mon May 27 11:52:32 2013 -0500

    Add unicode support for ID tokens

    Fixes handlebars-lang#433
    Fixes handlebars-lang#469

commit bff71d7
Author: kpdecker <[email protected]>
Date:   Sat May 25 12:32:16 2013 -0500

    Update release notes

commit 4d95d58
Author: kpdecker <[email protected]>
Date:   Sat May 25 12:27:31 2013 -0500

    Rebuild

commit 47e0aa7
Merge: 6bf9c6f f5fe6d0
Author: Kevin Decker <[email protected]>
Date:   Sat May 25 10:07:46 2013 -0700

    Merge pull request handlebars-lang#526 from jamesgorrie/master

    Fixing regex on partial names

commit 6bf9c6f
Merge: 533be69 10669e0
Author: kpdecker <[email protected]>
Date:   Wed May 22 08:40:28 2013 -0400

    Merge branch 'master' of github.com:wycats/handlebars.js

commit 533be69
Author: kpdecker <[email protected]>
Date:   Tue May 21 13:12:11 2013 -0500

    Use better variable name

commit a97820f
Author: kpdecker <[email protected]>
Date:   Tue May 21 13:03:41 2013 -0500

    Update testing notes

    Fixes handlebars-lang#467

commit f6b6361
Author: kpdecker <[email protected]>
Date:   Tue May 21 13:03:01 2013 -0500

    Fix typo

commit 10669e0
Merge: 5ba17c9 69bcdf3
Author: Kevin Decker <[email protected]>
Date:   Tue May 21 08:46:27 2013 -0700

    Merge pull request handlebars-lang#533 from blessenm/amd-precompilation-fix

    Fix for the issue handlebars-lang#517

commit 69bcdf3
Author: Blessan Mathew <[email protected]>
Date:   Tue May 21 20:50:46 2013 +0530

    Fix for issue handlebars-lang#517.

    Now when compiiled with amd option and a single input argument, we are
    checking to see whether the input is a file or folder.

commit 5ba17c9
Merge: 7fb9750 94cc419
Author: kpdecker <[email protected]>
Date:   Sun May 19 11:47:01 2013 -0500

    Merge branch 'master' of github.com:wycats/handlebars.js

commit 7fb9750
Author: kpdecker <[email protected]>
Date:   Sun May 19 11:45:20 2013 -0500

    Update block helper docs in README

    Fixes handlebars-lang#231, handlebars-lang#259

commit c95d9d6
Author: kpdecker <[email protected]>
Date:   Sun May 19 11:30:26 2013 -0500

    Use context rather than arg in README examples

commit 3aef7f6
Author: kpdecker <[email protected]>
Date:   Sun May 19 11:30:04 2013 -0500

    Misc readme updates

commit f5fe6d0
Author: James Gorrie <[email protected]>
Date:   Fri May 17 16:58:34 2013 +0100

    Allowed for points to be in partial path name

commit 94cc419
Merge: 4cf0410 d649b35
Author: Kevin Decker <[email protected]>
Date:   Tue May 14 21:10:14 2013 -0700

    Merge pull request handlebars-lang#515 from jjclark1982/master

    Allow requiring ".handlebars" files within Node.js scripts

commit d649b35
Author: Jesse Clark <[email protected]>
Date:   Wed May 15 10:50:01 2013 +1000

    Only run "require" tests when require() is available

commit 229b82b
Author: Jesse Clark <[email protected]>
Date:   Wed May 15 10:38:45 2013 +1000

    Add unit tests for require() handler

commit 531be77
Author: Jesse Clark <[email protected]>
Date:   Tue May 14 22:26:20 2013 +1000

    Publish a Node.js require() handler for handlebars files

commit 4cf0410
Author: kpdecker <[email protected]>
Date:   Mon May 13 23:09:21 2013 -0500

    1.0.11

commit 2ec5a97
Author: kpdecker <[email protected]>
Date:   Mon May 13 23:08:43 2013 -0500

    Update release notes

commit ddc4d31
Author: kpdecker <[email protected]>
Date:   Mon May 13 23:07:29 2013 -0500

    Rev to rc4

commit 85dd394
Author: kpdecker <[email protected]>
Date:   Fri May 10 01:35:25 2013 -0500

    Add regex escapes

commit 8b65fa7
Author: kpdecker <[email protected]>
Date:   Fri May 10 01:24:11 2013 -0500

    Update release notes

commit fa6cec2
Author: kpdecker <[email protected]>
Date:   Fri May 10 01:02:13 2013 -0500

    Update client packager versions

commit 436973f
Author: kpdecker <[email protected]>
Date:   Fri May 10 01:00:39 2013 -0500

    Version update script

commit a279678
Merge: d355d1f 8a5705a
Author: Kevin Decker <[email protected]>
Date:   Thu May 9 22:37:23 2013 -0700

    Merge pull request handlebars-lang#505 from MikeMayer/master

    Include a .nuspec package file to include handlebars.js on NuGet

commit d355d1f
Author: Kevin Decker <[email protected]>
Date:   Fri May 10 00:35:05 2013 -0500

    Fix links in release notes

commit 71c5e36
Merge: 44ae572 fc52a65
Author: Kevin Decker <[email protected]>
Date:   Thu May 9 22:29:27 2013 -0700

    Merge pull request handlebars-lang#489 from DevinClark/bower-update

    Added a component.json file for Twitter's Bower package manager.

commit 44ae572
Author: kpdecker <[email protected]>
Date:   Fri May 10 00:14:55 2013 -0500

    Add release notes

    Fixes handlebars-lang#471

commit 7cd9cdb
Merge: ef32573 090ee7c
Author: Kevin Decker <[email protected]>
Date:   Thu May 9 21:03:03 2013 -0700

    Merge pull request handlebars-lang#513 from tommydudebreaux/master

    Using handlebars with browserify causes IE to throw - TypeError: Invalid calling object

commit 090ee7c
Author: Tommy Messbauer <[email protected]>
Date:   Thu May 9 17:17:34 2013 -0500

    added local pointer to handlerbars.utils to allow this to browserify properly for IE

commit 8a5705a
Author: MikeMayer <[email protected]>
Date:   Wed May 1 09:58:17 2013 -0700

    Explicitly only include the handlebars.js from the dist folder

commit 344bb90
Author: MikeMayer <[email protected]>
Date:   Wed May 1 09:52:55 2013 -0700

    Create handlebars.js.nuspec for inclusion in NuGet

    Added a .nuspec file for those people who use Visual Studio and NuGet and might want to use handlebars.js deployed from NuGet in their application.

commit fc52a65
Author: DevinClark <[email protected]>
Date:   Thu Apr 25 21:05:21 2013 -0500

    Changed component.json to bower.json per Bower 0.9.0 update.

commit 5c9aa9e
Author: DevinClark <[email protected]>
Date:   Mon Apr 8 12:28:13 2013 -0500

    Added a component.json file for Twitter's Bower package manager.

    See [https://github.com/twitter/bower#defining-a-package](Defining a
    package) for more information about how the file was generated.
@damassi damassi mentioned this pull request Jun 7, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panthershark @kpdecker