(error) Changes for Mustache compatibility & latest version of therubyracer #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mustache compatibility
I'm in the process of changing a project to use Handlebars templates, and found a couple of differences between the way that Handlebars and Mustache work. Two of the commits in this pull request change Handlebars to be compatible with:
Getting going
I also had problems getting the tests to run in the first place. There are two more commits to fix the developer documentation and add the this argument to procs as required by therubyracer.
Jison problem?
There are three test failures which I couldn't fix, which look like this:
Failure/Error: lambda { ast_for("{{foo}") }.should raise_error(V8::JSError, /Parse error on line 1/)
expected V8::JSError with message matching /Parse error on line 1/, got #<V8::JSError: Cannot read property '0' of undefined>
./spec/parser_spec.rb:249
This may be a jison issue; it generates this code:
which, if action === undefined, will then immediately evaluate action[0], which will throw this error.
I'm using jison 0.3.8.